Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix borderRadius Android #51

Closed
wants to merge 1 commit into from
Closed

Conversation

enstulen
Copy link

@enstulen enstulen commented Apr 14, 2017

Fixes borderRadius on Android. Based on @bsinc's solution facebook/react-native#3198

@oblador
Copy link
Owner

oblador commented May 3, 2017

Thanks for your PR! Tried your code with a background color that's not white and and it would add an outline (on iOS too). Is there a way to solve this properly?

skarmavbild 2017-05-03 kl 19 58 18

@pavloko
Copy link

pavloko commented Aug 15, 2017

Hi @oblador! It seems like to apply this workaround we'd need to add background color prop to avoid the different color in the outline. I'm not sure how to evaluate the magnitude of underlying problem described in react-native/#3198, so I can't make a definite recommendation. Do you think it makes sense to introduce this or is it better to wait for a fix in react-native?

Something like:

const fixCircleClipping = {
     ...
     borderColor: this.props.backgroundColorOfParentElement
};

@oblador
Copy link
Owner

oblador commented Aug 15, 2017

@pavloko Right, that might be an acceptable workaround for now as it doesn't seem to happen in core any time soon. Would you mind updating the PR @enstulen?

@ddaeschler
Copy link

I've patched in the backgroundColorOfParentElement change in an up to date fork. Would you like a new PR for this issue?

@AndrewTHuang
Copy link

Has there been any progress on this one? @enstulen @pavloko @ddaeschler @oblador

@rochamorelli
Copy link

rochamorelli commented Nov 8, 2017

@AndrewTHuang facing this now, maybe it is not fixed

@oblador
Copy link
Owner

oblador commented Mar 24, 2018

Is this still an issue? Appears to be fixed by facebook/react-native@30044fd?

@oblador
Copy link
Owner

oblador commented May 31, 2018

Closing as I believe it's fixed in RN 0.50 and no replies to the contrary

@oblador oblador closed this May 31, 2018
@DnEgorWeb
Copy link

Seems like this issue still exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants