feat(apply): Support sources and processors #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirianni
commented
Mar 13, 2024
Comment on lines
+109
to
+117
| if [ -z "$configuration_path" ]; then | ||
| echo "configuration_path is required." | ||
| exit 1 | ||
| fi | ||
|
|
||
| if [ -z "$destination_path" ]; then | ||
| echo "destination_path is required." | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
These checks should have existed in the first place.
cpheps
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BindPlane v1.47.0 introduced the resource library. This allows users to save sources and processors, to be shared by multiple configurations.
This PR allows users to apply sources and processors.
Changes
source_pathandprocessor_pathoptionsTesting
I added sources and processors to my test environment resource library.
I updated my example repo here: https://github.com/jsirianni/bindplane-gitops-example/blob/main/.github/workflows/bindplane.yml
It includes the new source and processor options as well as the updated configurations that point to the library resources instead of having them configured inline.
After adding the library resources, I confirmed that updates to sources were automatically applied to configurations that used them, and the automatic rollout feature was triggered.
https://github.com/jsirianni/bindplane-gitops-example/actions/runs/8267177240/job/22616932539