Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use /client for react-dom #1872

Merged
merged 1 commit into from
Dec 9, 2024
Merged

use /client for react-dom #1872

merged 1 commit into from
Dec 9, 2024

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Dec 9, 2024

Alternative to #1870. Fixes #1866.

It sounds like you tried this already (“I'm trying to see if we can reroute "npm:react-dom" to "npm:react-dom/client" for asc. compat. (NO)”) but it works for me?

@mbostock mbostock requested a review from Fil December 9, 2024 05:43
@Fil
Copy link
Contributor

Fil commented Dec 9, 2024

I had not tried this exactly. Great!

@mbostock mbostock merged commit 6d455ac into main Dec 9, 2024
4 checks passed
@mbostock mbostock deleted the mbostock/react-19 branch December 9, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Framework v1.13 building a broken version of React 19
2 participants