Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a reducer expects numeric input but is given non-numeric input, it should raise an error. #473

Open
mbostock opened this issue Aug 1, 2021 · 0 comments · May be fixed by #487
Open

When a reducer expects numeric input but is given non-numeric input, it should raise an error. #473

mbostock opened this issue Aug 1, 2021 · 0 comments · May be fixed by #487
Labels
documentation Improvements or additions to docs

Comments

@mbostock
Copy link
Member

mbostock commented Aug 1, 2021

Following up on #399 (comment). For example, if you pass ordinal data (strings) to a sum reducer, Plot could detect that and raise a helpful error rather than producing NaN output.
@mbostock mbostock added the documentation Improvements or additions to docs label Aug 1, 2021
@mbostock mbostock changed the title When a reducer excepts numeric input but is given non-numeric input, it should raise an error. When a reducer expects numeric input but is given non-numeric input, it should raise an error. Aug 1, 2021
Fil added a commit that referenced this issue Aug 7, 2021
@Fil
Raise an error when a reducer expects numeric input but is given non-…
4ff6504 
…numeric input

Add tests for the normalize transform
closes #473
@Fil Fil linked a pull request Aug 7, 2021 that will close this issue
Draft
Fil added a commit that referenced this issue Feb 6, 2023
@Fil
Add tests for the normalize transform
d88610b 
closes #473
@Fil Fil mentioned this issue Sep 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Raise an error when a reducer expects numeric input but is given non-numeric input observablehq/plot
1 participant
@mbostock