Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waffle href #2203

Merged
merged 4 commits into from
Oct 19, 2024
Merged

waffle href #2203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1aab3b
waffle href
Fil Oct 19, 2024
00ae5ec
fix syntax
mbostock Oct 19, 2024
482f14c
ariaLabel, href; fix test
mbostock Oct 19, 2024
54515cd
test title, too
mbostock Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/marks/waffle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export class WaffleY extends BarY {

function waffleRender(y) {
return function (index, scales, values, dimensions, context) {
const {ariaLabel, href, title, ...visualValues} = values;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this needs to be done somewhere else in the future, we should probably instead split applyChannelStyles into two functions (applyChannelStyles and applyChannelSemantics).

const {unit, gap, rx, ry, round} = this;
const {document} = context;
const Y1 = values.channels[`${y}1`].value;
Expand Down Expand Up @@ -86,7 +87,7 @@ function waffleRender(y) {
.attr("id", (i) => `${patternId}-${i}`)
.select("rect")
.call(applyDirectStyles, this)
.call(applyChannelStyles, this, values)
.call(applyChannelStyles, this, visualValues)
)
.call((g) =>
g
Expand All @@ -104,6 +105,7 @@ function waffleRender(y) {
)
.attr("fill", (i) => `url(#${patternId}-${i})`)
.attr("stroke", this.stroke == null ? null : (i) => `url(#${patternId}-${i})`)
.call(applyChannelStyles, this, {ariaLabel, href, title})
)
.node();
};
Expand Down
Loading