feat(collection): enable cloudwatch logs discovery

Configure daily discovery event. This can be hardcoded to reduce
configuration fatigue.

As a result of this change, we can no longer explicitly configure
subscription filters, since there is a possibility of race condition
between "discovery" and the explicit filter. If a user wants to
forward the log groups created by the stack, they would have to provide
the stack name as one of the LogGroupPatterns.

apps/collection/template.yaml

@@ -233,34 +233,6 @@ Resources:
         Prefix: "cloudwatchlogs/"
         WriterRoleService: "logs.amazonaws.com"
         NameOverride: !Ref NameOverride
-  ForwarderLogGroupSubscription:
-    Type: AWS::Logs::SubscriptionFilter
-    Properties:
-      DestinationArn: !GetAtt
-        - Firehose
-        - Outputs.Firehose
-      FilterName: 'observe-logs-subscription'
-      FilterPattern: ''
-      LogGroupName: !GetAtt
-        - Forwarder
-        - Outputs.LogGroupName
-      RoleArn: !GetAtt
-        - Firehose
-        - Outputs.WriterRole
-  FirehoseLogGroupSubscription:
-    Type: AWS::Logs::SubscriptionFilter
-    Properties:
-      DestinationArn: !GetAtt
-        - Firehose
-        - Outputs.Firehose
-      FilterName: 'observe-logs-subscription'
-      FilterPattern: ''
-      LogGroupName: !GetAtt
-        - Firehose
-        - Outputs.LogGroupName
-      RoleArn: !GetAtt
-        - Firehose
-        - Outputs.WriterRole
   Subscriber:
     Type: AWS::Serverless::Application
     Condition: EnableSubscriber
@@ -278,22 +250,8 @@ Resources:
           - Outputs.WriterRole
         LogGroupNamePrefixes: !Join [",", !Ref LogGroupNamePrefixes]
         LogGroupNamePatterns: !Join [",", !Ref LogGroupNamePatterns]
+        DiscoveryRate: "24 hours"
         NameOverride: !Ref NameOverride
-  SubscriberLogGroupSubscription:
-    Type: AWS::Logs::SubscriptionFilter
-    Condition: EnableSubscriber
-    Properties:
-      DestinationArn: !GetAtt
-        - Firehose
-        - Outputs.Firehose
-      FilterName: 'observe-logs-subscription'
-      FilterPattern: ''
-      LogGroupName: !GetAtt
-        - Subscriber
-        - Outputs.LogGroupName
-      RoleArn: !GetAtt
-        - Firehose
-        - Outputs.WriterRole
 
 Outputs:
   Bucket:

integration/tests/collection.tftest.hcl

@@ -81,6 +81,10 @@ variables {
           "s3:ListBucket",
           "s3:PutBucketNotification",
           "s3:PutLifecycleConfiguration",
+          "scheduler:GetSchedule",
+          "scheduler:CreateSchedule",
+          "scheduler:UpdateSchedule",
+          "scheduler:DeleteSchedule",
           "sns:CreateTopic",
           "sns:DeleteTopic",
           "sns:GetTopicAttributes",