Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(collection): enable cloudwatch logs discovery #136

Merged
merged 1 commit into from
Dec 14, 2023
Merged

feat(collection): enable cloudwatch logs discovery #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 1 addition & 43 deletions apps/collection/template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,34 +233,6 @@ Resources:
Prefix: "cloudwatchlogs/"
WriterRoleService: "logs.amazonaws.com"
NameOverride: !Ref NameOverride
ForwarderLogGroupSubscription:
Type: AWS::Logs::SubscriptionFilter
Properties:
DestinationArn: !GetAtt
- Firehose
- Outputs.Firehose
FilterName: 'observe-logs-subscription'
FilterPattern: ''
LogGroupName: !GetAtt
- Forwarder
- Outputs.LogGroupName
RoleArn: !GetAtt
- Firehose
- Outputs.WriterRole
FirehoseLogGroupSubscription:
Type: AWS::Logs::SubscriptionFilter
Properties:
DestinationArn: !GetAtt
- Firehose
- Outputs.Firehose
FilterName: 'observe-logs-subscription'
FilterPattern: ''
LogGroupName: !GetAtt
- Firehose
- Outputs.LogGroupName
RoleArn: !GetAtt
- Firehose
- Outputs.WriterRole
Subscriber:
Type: AWS::Serverless::Application
Condition: EnableSubscriber
Expand All @@ -278,22 +250,8 @@ Resources:
- Outputs.WriterRole
LogGroupNamePrefixes: !Join [",", !Ref LogGroupNamePrefixes]
LogGroupNamePatterns: !Join [",", !Ref LogGroupNamePatterns]
DiscoveryRate: "24 hours"
NameOverride: !Ref NameOverride
SubscriberLogGroupSubscription:
Type: AWS::Logs::SubscriptionFilter
Condition: EnableSubscriber
Properties:
DestinationArn: !GetAtt
- Firehose
- Outputs.Firehose
FilterName: 'observe-logs-subscription'
FilterPattern: ''
LogGroupName: !GetAtt
- Subscriber
- Outputs.LogGroupName
RoleArn: !GetAtt
- Firehose
- Outputs.WriterRole

Outputs:
Bucket:
Expand Down
4 changes: 4 additions & 0 deletions integration/tests/collection.tftest.hcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ variables {
"s3:ListBucket",
"s3:PutBucketNotification",
"s3:PutLifecycleConfiguration",
"scheduler:GetSchedule",
"scheduler:CreateSchedule",
"scheduler:UpdateSchedule",
"scheduler:DeleteSchedule",
"sns:CreateTopic",
"sns:DeleteTopic",
"sns:GetTopicAttributes",
Expand Down
Loading