ci: improve release robustness #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reorders operations in order to reduce the scope for error in case of a CI failure. We run the release job concurrently for each region. If any job fails, all other jobs are interrupted. This opened the possibility for the root `packaged.yaml` template to be uploaded, but with incorrect ACLs. We should always copy the template with the ACL directive. This eliminates the possibility of the object existing with the incorrect permissions. Furthermore, we should only upload the template once all objects it refers to are also publicly readable. That way we ensure that if the template is accessible, it is also installable. In debugging this issue I also uncovered we were building things twice: once for the version (e.g. `1.2.0`), and again for the tag (e.g. `beta`). There is no reason to rebuild things a second time, all we need is to ensure the `packaged.yaml` is placed in the correct destination. This has the advantage of reducing build time, avoiding build discrepancies, and ensuring the `version` embedded in the binary always refers to a concrete version rather then tag. As a result of "symlinking" the file, we no longer need to protect against a folder ballooning in size over successive builds. `latest/` and `beta/` should now only contain one file.
|
🎉 This PR is included in version 1.19.1-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.19.1-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.19.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reorders operations in order to reduce the scope for error in case of a CI failure.
We run the release job concurrently for each region. If any job fails, all other jobs are interrupted. This opened the possibility for the root
packaged.yamltemplate to be uploaded, but with incorrect ACLs.We should always copy the template with the ACL directive. This eliminates the possibility of the object existing with the incorrect permissions. Furthermore, we should only upload the template once all objects it refers to are also publicly readable. That way we ensure that if the template is accessible, it is also installable.