fix(forwarder): improve CSV handling #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jta
force-pushed
the
joao/csv
branch
2 times, most recently
from
238cca6
to
993878b
Compare
| } | ||
|
|
||
| // avoid unmarshalling if possible | ||
| if r, ok := v.(*json.RawMessage); ok { |
There was a problem hiding this comment.
no additional tests for this new branch?
There was a problem hiding this comment.
This is actually the only case we test today, since both the tests and the runner use json.RawMessage. Arguably we could add a testcase for the unused path, but that was tested prior so we do know it works. We would be ensuring that it continues to work going forward. I've update the test to verify this slow path. The test results differ due to key reordering (when we go through json.Unmarshal, keys are ordered alphabetically)
A few simple performance fixes for converting CSV to JSON: - avoid unmarshalling if target is json.RawMessage, since that calls `json.Valid`. - avoid calling `strconv.Quote` where possible. Most of the inputs we handle in practice do not require special handling. - keep track of max record length and use it to initialize our buffer, which avoids resizing. In profiling, these changes reduced processing time for a VPC flow logs file by ~33%.
obs-gh-alexlew
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few simple performance fixes for converting CSV to JSON:
json.Valid.strconv.Quotewhere possible. Most of the inputs we handle in practice do not require special handling.In profiling, these changes reduced processing time for a VPC flow logs file by ~33%.