Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OB-38134 make parent stack outputs conditioned on nested stack #349

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

obs-gh-virjramakrishnan
Copy link
Collaborator

fix to correct logs to work when subscriber is not enabled

@@ -220,7 +220,21 @@ Conditions:
- !Equals
- !Ref DatasourceID
- ""

HasLogGroupNamePatterns: !Not
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a * sentinel value that's valid for this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can enter * for LogGroupNamePatterns and it will collect everything, yes

@obs-gh-virjramakrishnan obs-gh-virjramakrishnan merged commit c05aaab into main Oct 24, 2024
16 checks passed
@obs-gh-virjramakrishnan obs-gh-virjramakrishnan deleted the viraj/fix-logs branch October 24, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants