Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subscriber): break out request types #78

Merged
merged 1 commit into from
Nov 14, 2023
Merged

feat(subscriber): break out request types #78

merged 1 commit into from
Nov 14, 2023

Conversation

jta
Copy link
Contributor

@jta jta commented Nov 9, 2023

Flesh out the two types of requests our handler will support. I'm purposely keeping implementation light so as to make reviews more tractable.

Flesh out the two types of requests our handler will support. I'm
purposely keeping implementation light so as to make reviews more
tractable.
Copy link
Contributor

@obs-gh-colinhutchinson obs-gh-colinhutchinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

future us should try to do some work so test failures are easily understood / actionable

@jta jta merged commit 5c6f6cc into main Nov 14, 2023
6 checks passed
@jta jta deleted the joao/discovery branch November 14, 2023 03:31
Copy link

🎉 This PR is included in version 1.1.0-beta.14 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants