-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: release automation #8
Conversation
SAM will handle uploading the stacks to an S3 bucket for us, which seems more appropriate than trying to figure out how to dynamically load the appropriate application Id.
feat: setup ci release logic
…se something is broken
{ | ||
"name": "release", | ||
"channel": false, | ||
"prerelease": false, | ||
"type": "maintenance" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for future historians: this is a hack to trick semantic-release that we want main
to do prereleases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to resolve why our assets are cross-contaminating.
my bucket colin-observeinc-us-east-1/apps/collection/1.4.0-beta.6/
has README, code, and cloudformation templates for both observe-aws-config
and observe-forwarder
edit: looks like this is how AWS SAM handles the fact that collection and config are dependent 🤔
I'd expect this in the case of nested stacks (rather than referring to external serverless repos). All assets are packaged as part of the same app. This does bring up a dilemma wrt versioning. Do we want one version for all apps (easier to maintain), or separate versions per app (more accurate from user perspective). |
chore: introduce dependabot
048e627
to
56bcd91
Compare
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR introduces automation for both github and aws release automation. There's more work that can (should) be done but in the interest of incremental improvements dropping a PR of what I have so far. The sequence of events from this PR to a release should be
todo:
colin
from the three spots in the codemain
or the automation gets befuddledmain
andrelease
github actions on main will then:
aws sam build
for every region / appreleased
official releases are ran as a manual workflow dispatch
end result screenshots
the release / tag
the pull request comment / label
the aws bucket result