feat(subscriber): add subscription diff logic #80
Conversation
jta
force-pushed
the
joao/subscription-filters
branch
from
df811e4
to
a1f8d08
Compare
There was a problem hiding this comment.
A question for future us: what does uninstalling look like?
A question for now: does an AWS step function make more sense then a full fledged SQS queue?
Edit to add: reading up on step function I don't think they make more sense here vs an sqs queue. Step functions look more relevant when conditional logic or coordination between multiple services is required
This is a good question. Past experience suggests that it's tricky to guarantee a clean uninstall, even if you managed to get a clean install, since you may have subscribed to far more log groups over time than were available on first install. My current approach is that for a quick uninstall, removing the destination ARN is enough. Since the subscriber will be almost always managed alongside the destination (in our case a firehose), deleting the firehose will leaving dangling subscriptions that have no effect. For a clean uninstall, you can always install the stack with no destination ARN. This will remove any filters which begin with |
First pass at fleshing out the `HandleSubscribe` endpoint. This is unlikely to have all the safeguards we need, but for now: - we only manage subscription filters which have our filter name as a prefix. - if there are already 2 filters, we do nothing The diffing function is broken out so that we can test it without involving AWS API stubs.
jta
force-pushed
the
joao/subscription-filters
branch
from
a1f8d08
to
45cf845
Compare
|
🎉 This PR is included in version 1.2.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
First pass at fleshing out the
HandleSubscribeendpoint. This is unlikely to have all the safeguards we need, but for now:The diffing function is broken out so that we can test it without involving AWS API stubs.