chore(release): make official releases pass the integration tests first #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendrucker
reviewed
Nov 17, 2023
obs-gh-colinhutchinson
force-pushed
the
chore/release-requires-tests
branch
3 times, most recently
from
3379f8c
to
ca700fe
Compare
obs-gh-colinhutchinson
force-pushed
the
chore/release-requires-tests
branch
from
ca700fe
to
98c7171
Compare
bendrucker
approved these changes
Nov 20, 2023
| pull_request: | ||
| workflow_dispatch: | ||
| workflow_call: |
There was a problem hiding this comment.
It's possible that this is optional when using secrets: inherit but it would be good practice to declare secrets regardless:
If you don't inherit I'm guessing any explicitly passed secrets would be rejected.
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be wired correctly.