Update golangci-lint (99designs#2103)

Signed-off-by: Steve Coffman <steve@khanacademy.org>
observeinc · Apr 18, 2022 · add6004 · add6004
1 parent 05d4008
commit add6004
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 20 deletions.
diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml
@@ -1,32 +1,35 @@
 name: Integration
 on: [push, pull_request]
 
+env:
+  GO_VERSION: 1.16
+
 jobs:
   integration:
     runs-on: ubuntu-latest
     timeout-minutes: 3
-    container: golang:1.16-alpine
+    container: golang:${{ env.GO_VERSION }}-alpine
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - run: apk add --no-cache --no-progress nodejs npm git bash
       - run: go mod download
       - run: cd integration ; npm install
       - run: .github/workflows/check-integration
 
   federation:
     runs-on: ubuntu-latest
-    container: golang:1.16-alpine
+    container: golang:${{ env.GO_VERSION }}-alpine
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - run: apk add --no-cache --no-progress nodejs npm git bash
       - run: go mod download
       - run: cd _examples/federation ; npm install
       - run: .github/workflows/check-federation
 
   init:
     runs-on: ubuntu-latest
-    container: golang:1.17-alpine
+    container: golang:${{ env.GO_VERSION }}-alpine
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - run: apk add --no-cache --no-progress alpine-sdk bash
       - run: .github/workflows/check-init
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -1,23 +1,28 @@
 name: Lint
 on: [push, pull_request]
 
+env:
+  GO_VERSION: 1.16
+
 jobs:
   lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-go@v2
-        with: { go-version: 1.16 }
+      - uses: actions/checkout@v3
+      - uses: actions/setup-go@v3
+        with:
+          go-version: ${{ env.GO_VERSION }}
       - run: go mod download
       - run: .github/workflows/check-fmt
       - run: .github/workflows/check-generate
 
   coverage:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-go@v2
-        with: { go-version: 1.16 }
+      - uses: actions/checkout@v3
+      - uses: actions/setup-go@v3
+        with:
+          go-version: ${{ env.GO_VERSION }}
       - run: go mod download
       - run: .github/workflows/check-coverage
         env:
@@ -26,10 +31,15 @@ jobs:
   golangci-lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-go@v2
-        with: { go-version: 1.16 }
+      - uses: actions/checkout@v3
+      - name: Install Go
+        uses: actions/setup-go@v3
+        with:
+          go-version: ${{ env.GO_VERSION }}
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v2
+        uses: golangci/golangci-lint-action@v3.1.0
         with:
-          version: v1.44.2
+          version: latest
+          # skip cache because of flaky behaviors
+          skip-build-cache: true
+          skip-pkg-cache: true
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -1,17 +1,21 @@
 name: Test
 on: [push, pull_request]
 
+
+env:
+  GO_VERSION: 1.16
+
 jobs:
   test:
     strategy:
       matrix:
-        go: [1.16]
+        go: [${{ env.GO_VERSION }}]
         os: [ubuntu-latest, windows-latest]
 
     runs-on: ${{ matrix.os }}
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-go@v2
+      - uses: actions/checkout@v3
+      - uses: actions/setup-go@v3
         with:
           go-version: ${{ matrix.go }}
       - run: go mod download && go test -race ./...