fix: set source
in required_providers
#36
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces the legacy
required_providers
declaration with{source, version}
.Motivation
Fixes warnings about implicit provider selection when passing in a provider instance to the module. Closes #31.
Limitations
Since Terraform continues to support this syntax for backward compatibility with 0.12, we need to enforce this separately. terraform-linters/tflint-ruleset-terraform#64 will allow us to detect and reject this syntax in the future.
Testing
I tried to write a test module but was unable to reproduce the originally reported warning on
terraform validate
:Even if there were no reported issue/warning, we should still be setting
source
anyway.