Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save compressed netcdf #21

Merged
merged 53 commits into from
Apr 7, 2022
Merged

save compressed netcdf #21

merged 53 commits into from
Apr 7, 2022

Conversation

aaronspring
Copy link
Collaborator

@aaronspring aaronspring commented Apr 5, 2022 •
edited
Loading

  • xr.Dataset.to_compressed_netcdf using get_compress_encoding
  • xr_bitround
  • doctests

@aaronspring aaronspring self-assigned this Apr 5, 2022
@aaronspring aaronspring added the enhancement New feature or request label Apr 5, 2022
AS and others added 15 commits April 6, 2022 13:31
add numcodecs to setup.py
7ffedfb
Merge branch 'save_compressed_netcdf' of https://github.com/observing…
951fbef 
…Clouds/bitinformation_pipeline into save_compressed_netcdf
fix init
5ef9a11
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
84e6fc9 
for more information, see https://pre-commit.ci
@aaronspring
Merge branch 'main' into save_compressed_netcdf
bc18481
fix
f80c6a6
Merge branch 'save_compressed_netcdf' of https://github.com/observing…
83068fe 
…Clouds/bitinformation_pipeline into save_compressed_netcdf
@aaronspring
Merge branch 'main' into save_compressed_netcdf
d04b814
fix _time_dim
7aab6d3
Merge branch 'save_compressed_netcdf' of https://github.com/observing…
8f2b880 
…Clouds/bitinformation_pipeline into save_compressed_netcdf
fix path.getsize
3203681
add dask to setup.py
0733266
requirements.txt
ad6b82c
test bitround test get_compress_encoding
99791e7
doctests conftest
2993ee5
@aaronspring aaronspring mentioned this pull request Apr 6, 2022
Closed
aaronspring
aaronspring commented Apr 6, 2022
View reviewed changes
tests/test_xr_bitround.py Outdated Show resolved Hide resolved
@aaronspring
Copy link
Collaborator Author

@observingClouds I suggest merging this now despite the issue how xr_bitround handles keepbits. then next I can implement jl_bitround and we can compare and fix?

@observingClouds
Copy link
Owner

Yes, feel free to merge! Could you create an issue though that we make sure to test we support not only float32.

@aaronspring aaronspring mentioned this pull request Apr 7, 2022
Closed
@aaronspring aaronspring merged commit 8fef5e6 into main Apr 7, 2022
@aaronspring aaronspring deleted the save_compressed_netcdf branch April 7, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milankl milankl milankl left review comments

@observingClouds observingClouds observingClouds approved these changes

Assignees

@aaronspring aaronspring

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronspring @observingClouds @milankl