Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aura Dark Theme #2259

Merged
merged 6 commits into from
Aug 15, 2023
Merged

Add Aura Dark Theme #2259

merged 6 commits into from
Aug 15, 2023

Conversation

possibly-not
Copy link
Contributor

@possibly-not possibly-not commented Aug 6, 2023

I am submitting a new Community Theme

Repo URL

Link to my theme: https://github.com/Possibly-Matt/obsidian-aura-theme

Theme checklist

  • My repo contains all required files (please do not add them to this obsidian-releases repo).
    • manifest.json
    • theme.css
    • The screenshot file (16:9 aspect ratio, recommended size is 512px by 288px for fast loading).
  • I have indicated which modes (dark, light, or both) are compatible with my theme.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other themes that I'm using. I have given proper attribution to these other themes in my README.md.

@github-actions
Copy link

github-actions bot commented Aug 6, 2023

Hello!

I found the following issues in your theme submission

Errors:

❌ You don't have a valid manifest.json at the root of your repo.


Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.
⚠️ We discourage themes from including the word theme in their name since it's redundant and makes the theme selection screen harder to visually parse.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@possibly-not
Copy link
Contributor Author

Fixed both the theme redundancy (good point 😅!) and fixed the version string to be actual semver version

@possibly-not possibly-not reopened this Aug 6, 2023
@github-actions
Copy link

github-actions bot commented Aug 6, 2023

Hello!

I found the following issues in your theme submission

Errors:

❌ You don't have a valid manifest.json at the root of your repo.


Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.
⚠️ We discourage themes from including the word theme in their name since it's redundant and makes the theme selection screen harder to visually parse.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@possibly-not possibly-not reopened this Aug 7, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Hello!

I found the following issues in your theme submission

Errors:

❌ You don't have a valid manifest.json at the root of your repo.


Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.
⚠️ We discourage themes from including the word theme in their name since it's redundant and makes the theme selection screen harder to visually parse.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

1 similar comment
@github-actions
Copy link

Hello!

I found the following issues in your theme submission

Errors:

❌ You don't have a valid manifest.json at the root of your repo.


Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.
⚠️ We discourage themes from including the word theme in their name since it's redundant and makes the theme selection screen harder to visually parse.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@joethei
Copy link
Collaborator

joethei commented Aug 15, 2023

hm, bot borked.

@github-actions
Copy link

Hello!

I found the following issues in your theme submission

Errors:

❌ There is already a theme with this name
❌ There is already a entry pointing to the Possibly-Matt/aura-theme repository
❌ You don't have a valid manifest.json at the root of your repo.


Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.
⚠️ We discourage themes from including the word theme in their name since it's redundant and makes the theme selection screen harder to visually parse.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions
Copy link

Hello!

I found the following issues in your theme submission

Errors:

❌ You don't have a valid manifest.json at the root of your repo.


Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.
⚠️ We discourage themes from including the word theme in their name since it's redundant and makes the theme selection screen harder to visually parse.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@joethei
Copy link
Collaborator

joethei commented Aug 15, 2023

ah, I see what's going on, the repo you linked too is not the same as the one in the list.

@github-actions
Copy link

Hello!

I found the following issues in your theme submission

Errors:

❌ Theme name mismatch, the name in this PR (Aura Dark Theme) is not the same as the one in your repo (Aura Dark). If you just changed your theme name, remember to change it in the manifest.json in your repo, and your latest GitHub release, if you have one.


Warnings:

⚠️ We discourage themes from including the word theme in their name since it's redundant and makes the theme selection screen harder to visually parse.
⚠️ The authorUrl field in your manifest should not point to the GitHub repository of the theme.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions
Copy link

Hello!

I found the following issues in your theme submission

Warnings:

⚠️ The authorUrl field in your manifest should not point to the GitHub repository of the theme.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@joethei joethei self-assigned this Aug 15, 2023
@joethei joethei merged commit 1136833 into obsidianmd:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants