Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: AI Chat as Markdown #3802

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

cpbotha
Copy link
Contributor

@cpbotha cpbotha commented Jul 1, 2024

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/cpbotha/obsidian-ai-chat-as-md

Release Checklist

  • [-] I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using. I have given proper attribution to these other projects in my README.md.

Copy link

github-actions bot commented Jul 1, 2024

Hello!

I found the following issues in your plugin submission

Errors:

❌ The authorUrl field in your manifest should not point to the GitHub repository of the plugin.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@cpbotha cpbotha closed this Jul 1, 2024
@cpbotha cpbotha reopened this Jul 1, 2024
@github-actions github-actions bot changed the title Add AI Chat as Markdown plugin Add plugin: AI Chat as Markdown Jul 1, 2024
@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, assigning human for additional review.

@joethei
Copy link
Collaborator

joethei commented Jul 4, 2024

"repo": "cpbotha/obsidian-ai-chat-as-md",
This is not part of the manifest, remove it.

openAIAPIKey: "sk-xxxx",
The default should be a empty string.

id: "ai-chat-complete-thread",, id: "ai-chat-complete-selection",
Remove the ai-chat prefix.

.setName("System Prompt")
Use sentence case in UI

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Jul 4, 2024
@cpbotha
Copy link
Contributor Author

cpbotha commented Jul 4, 2024

Thank you very much @joethei

I was preparing a 1.2.0 release with a minor new feature (replace selection), so I could include all five of your requested changes with that. Please see https://github.com/cpbotha/obsidian-ai-chat-as-md/releases/tag/1.2.0

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Jul 4, 2024
@cpbotha cpbotha force-pushed the cpb-add-ai-chat-as-markdown branch 2 times, most recently from 4a28ae4 to e169771 Compare July 5, 2024 20:48
@joethei joethei force-pushed the cpb-add-ai-chat-as-markdown branch from e169771 to 76570fe Compare July 5, 2024 21:36
@joethei joethei merged commit 7aa6838 into obsidianmd:master Jul 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants