-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #259
Update dependencies #259
Conversation
I originally attempted to update libajantv2 from 17.0.1 to 17.1.0, however:
The second item causes an error at the fixup step of that script on Windows. SRT and MbedTLS are not updated for the same reason as before:
RNNoise is not updated for the same reason as before:
Librist is not updated for the same reason as before:
|
Good newsOBS builds in Debug, RelWithDebInfo, and Release. These worked:
Almost everything in my typical tests for those features worked. Bad NewsThese had issues:
The Image Slide Show source is created with its center origin in the lower right corner of the scene. I don't think this is related to deps though. It is more likely to be related to changes in the obs-studio repo. My first attempt to stream HLS to YouTube resulted in this error once:
The second attempt did not emit an error, but did not show up on YouTube. The third attempt connected and showed up on YouTube, so perhaps this was just HLS fussiness and intermittent network issues. These did not work:
Attempting to stream to Twitch or Broadcast Box with WHIP hit a debug breakpoint:
cc @Sean-Der , but I will just revert the libdatachannel update back to v0.21.0 since it seemed to be working with that. Todo
Also, building and testing on macOS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine - I'm not aware of any new compiler or binary issues with the updated dependencies.
I just need to revert the libdatachannel update and see about testing AMF/NVENC to be sure those work. |
Description
Update dependencies where possible:
Motivation and Context
Want to update dependencies when we have the opportunity.
How Has This Been Tested?
I have tested that these dependencies themselves can be compiled on Windows. I haven't yet done test builds with OBS or full testing in OBS. That will be forthcoming.
Types of changes
Checklist: