obs-ffmpeg: Fix for FFmpeg 6 deprecating a flag #8376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It didn't deprecated it, it dropped it FFmpeg/FFmpeg@3ceffe7. |
oh thanks, i'll correct |
derrod
reviewed
Feb 28, 2023
Also modifies libobs & deps/media-playback. AV_CODEC_CAP_TRUNCATED was removed in avcodec 60 [1]. We ifdef the code depending on it to allow compilation. [1] avcodec: remove FF_API_FLAG_TRUNCATED FFmpeg/FFmpeg@3ceffe7 Signed-off-by: pkv <pkv@obsproject.com>
This was referenced Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also modifies libobs & deps/media-playback.
AV_CODEC_CAP_TRUNCATED was removed by avcodec 60 [1]. We ifdef the code depending on it to allow compilation.
[1] avcodec: remove FF_API_FLAG_TRUNCATED
FFmpeg/FFmpeg@3ceffe7
Motivation and Context
Allow compilation of obs with FFmpeg 6.
Fixes #8375
How Has This Been Tested?
Tested with FFmpeg master as of Feb. 28 2023 (67fd1b79 libavcodec/hevc: remove duplicate semicolon in hevcdsp_init_neon).
Obs compiles fine with the new dlls.
Checked that Media Source works.
Checked that recording works (to mkv).
Checked that remuxing works (to mp4).
Checked that streaming to Twitch still works.
Types of changes
Checklist: