Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: loop level links #1507

Merged
merged 22 commits into from
Oct 30, 2023
Merged

feat: loop level links #1507

merged 22 commits into from
Oct 30, 2023

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Oct 30, 2023

This change is Reviewable

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @SKairinos)


game/messages.py line 2435 at r1 (raw file):

    lambda: "Which way to turn? This way or that way?",
    lambda: build_description(title_level115(), "Try to find the shortest route using Python code only. You are getting really good at this!"),
    lambda: "If you are stuck on this one, check that the you are using the Python commands accurately. Click the Py Commands button to help you.",

please remove the unnecessary "the" after "check that"


game/migrations/0084_loop_levels.py line 229 at r1 (raw file):

        episode=episode_12,
        path="",
        # next_level=level_123, TODO: connect them when the next levels are enabled.

If we do this it stops the user from loading the next level from the UI but the users could technically still load levels 122 onwards by putting the level number in the URL. Do we want to add something in to prevent this?


game/migrations/0084_loop_levels.py line 310 at r1 (raw file):

class Migration(migrations.Migration):
    dependencies = [("game", "0083_add_cows_to_existing_levels")]

You haven't merged in master - the latest PR brings in migrations 84 and 85 so you'll need to rename this one 86 and make it dependent on 85 instead.

Copy link
Contributor Author

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 7 files reviewed, 3 unresolved discussions (waiting on @faucomte97)


game/messages.py line 2435 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

please remove the unnecessary "the" after "check that"

Done.


game/migrations/0084_loop_levels.py line 229 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

If we do this it stops the user from loading the next level from the UI but the users could technically still load levels 122 onwards by putting the level number in the URL. Do we want to add something in to prevent this?

I think it's fine because it will fail to load the level anyways, letting them know they shouldn't be doing that


game/migrations/0084_loop_levels.py line 310 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

You haven't merged in master - the latest PR brings in migrations 84 and 85 so you'll need to rename this one 86 and make it dependent on 85 instead.

Done.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@faucomte97 faucomte97 merged commit f2dd9ed into master Oct 30, 2023
3 checks passed
@faucomte97 faucomte97 deleted the loop_level_links branch October 30, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants