Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable automatic Christmas theme in December #1538

Merged
merged 6 commits into from
Nov 30, 2023

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Nov 24, 2023

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Nov 24, 2023
Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 26 of 27 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)


game/decor.py line 70 at r2 (raw file):

        # FUTURE: add external branding option
        url="decor/grass/cfc.svg",
        xmas_url="decor/grass/cfc.svg",

not snow/cfc.svg?

Copy link
Contributor Author

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)


game/decor.py line 70 at r2 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

not snow/cfc.svg?

Good catch, thanks

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #1538 (1cf947e) into master (31dde05) will increase coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 1cf947e differs from pull request most recent head 0776a97. Consider uploading reports for the commit 0776a97 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1538      +/-   ##
==========================================
+ Coverage   91.79%   91.80%   +0.01%     
==========================================
  Files         110      110              
  Lines        5860     5871      +11     
==========================================
+ Hits         5379     5390      +11     
  Misses        481      481              
Files Coverage Δ
game/character.py 100.00% <ø> (ø)
game/decor.py 78.78% <100.00%> (+0.66%) ⬆️
game/level_management.py 89.77% <ø> (ø)
game/theme.py 100.00% <ø> (ø)
game/views/level.py 74.44% <100.00%> (+1.17%) ⬆️

Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@faucomte97 faucomte97 merged commit 8cb7edd into master Nov 30, 2023
5 of 6 checks passed
@faucomte97 faucomte97 deleted the automatic_rudolph branch November 30, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants