-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable automatic Christmas theme in December #1538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 26 of 27 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)
game/decor.py
line 70 at r2 (raw file):
# FUTURE: add external branding option url="decor/grass/cfc.svg", xmas_url="decor/grass/cfc.svg",
not snow/cfc.svg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)
game/decor.py
line 70 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
not snow/cfc.svg?
Good catch, thanks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1538 +/- ##
==========================================
+ Coverage 91.79% 91.80% +0.01%
==========================================
Files 110 110
Lines 5860 5871 +11
==========================================
+ Hits 5379 5390 +11
Misses 481 481
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
This change is