-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove direct drive arrows #1743
Conversation
@faucomte97 Do I really need to make my email address public on a GitHub page to sign the agreement? 😬 I like the idea of validating this automatically, but I'm sure there is a better way that doesn't involve making personal information publicly available. E.g. adding the private GitHub email address should work technically; storing the usernames and email addresses in a database and making an API endpoint to check the GitHub username rather than the email address would also work. |
@razvan-pro No worries about that atm, we are about to put in place a completely new system which won't require contributors to publicise their email address. We're essentially building a "contributor service" which will allow users to login via Github, and agree to the contributor agreement directly on there without needing to a) edit the contributor agreement file and b) respond to an email - so it'll be a lot smoother 🙂 I can let you know once we've deployed this so you don't need to follow the old process Edit: And essentially yes, the contributor service we've built does what you've suggested 😃 |
@faucomte97 That's an excellent solution, thanks for this! I had something like this in mind, but I thought it might be too high effort to suggest - it's great to see it's already in progress! 😊 Yes please, let me know when it's deployed. 🙏 Do you think it will be ready in time to merge this PR by the end of October for the hacktoberfest? 😁 |
@razvan-pro thanks 😃 Unfortunately I don't think we'll have the service up and running by the end of the month... We were thinking, would you be happy to use a "temporary" email address for this purpose? Like a new gmail address for example that you'd use only for contributing - you could have that be public and the we could then verify it, until we release the new service. What this means though is that you'd need to close this PR and make a new one authored by that new email address, but hopefully it shouldn't take too long 😬 Let us know what you think |
@faucomte97 I was about to do that, but it looks like if I remove the email address later from my account, the commits won't be associated with my account anymore 😬 so I'd have to keep the temporary email address. I think I'll wait for the new service (it's fine if it's outside hacktoberfest). I assume adding the private github email to the list won't work, right? From what I saw, there's an action that sends the agreement automatically, so I wouldn't want to break things 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @razvan-pro)
Description
direct_drive
attribute from theLevel
model and all relations to it from the frontend. This will remove the direct drive arrows mentioned in Remove direct drive arrows #1662..direct_drive_button
to.zoom_pan_button
as it's only used for the zoom buttons now._setupDirectDriveListeners
JS functions as it's no longer used when the direct drive buttons are removed.How Has This Been Tested?
Screenshots
Direct drive buttons removed
Go button replaced with Play icon and text in level description
Checklist:
This change is