Remove -rectypes
from BatFingerTree, simplify the implementation
#1012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option
-rectypes
has a non-obvious impact on the type theory of OCaml, it is better to not require it for some modules.-rectypes
was used in the implementation of enumeration of finger trees, to implement a specific form of continuation-passing-style. The new implementation uses plain old datatypes, so it is simpler (and shorter). Benchmarking suggests that there are no performance differences.