Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List.unique_cmp tweak #852

Merged
merged 2 commits into from
Mar 22, 2018
Merged

List.unique_cmp tweak #852

merged 2 commits into from
Mar 22, 2018

Conversation

murmour
Copy link
Contributor

@murmour murmour commented Mar 22, 2018

Self-explanatory.

@murmour
Optimization of List.unique_cmp
af81afb 
A set should be more efficient than [bool PMap.t].
@murmour
Add ChangeLog entry
f744be4
@gasche
Copy link
Member

gasche commented Mar 22, 2018

I'm curious now. Does it actually go any faster, or at least use less memory?

@murmour
Copy link
Contributor Author

murmour commented Mar 22, 2018 •
edited
Loading

A set uses one word less memory per each node of a tree, which potentially affects performance. I didn't actually benchmark it.

@gasche gasche merged commit be9a426 into ocaml-batteries-team:master Mar 22, 2018
@murmour
Copy link
Contributor Author

murmour commented Mar 22, 2018

By the way, a hash table should be a much better option here, but that change would require a proper benchmark.

@gasche gasche mentioned this pull request Sep 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murmour @gasche