Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Int32/64.pow for negative exponents #990

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Fix Int32/64.pow for negative exponents #990

merged 2 commits into from
Nov 30, 2020

Conversation

rixed
Copy link
Contributor

@rixed rixed commented Nov 27, 2020

Closes #989

@rixed rixed requested a review from UnixJunkie November 27, 2020 15:33
@UnixJunkie
Copy link
Member

You don't want to be able to compute 2^(-3) ?
It seems valid to me.

@UnixJunkie
Copy link
Member

Ok, because the return type is int.

@UnixJunkie UnixJunkie merged commit 86f5e37 into ocaml-batteries-team:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UnixJunkie UnixJunkie Awaiting requested review from UnixJunkie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stack overflow on Int{32,64}.pow with negative exponent
2 participants
@rixed @UnixJunkie