Fix behavior of utop -stdin #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks |
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
Jul 3, 2023
CHANGES: * Fix behavior of utop -stdin (ocaml-community/utop#434, fixes ocaml-community/utop#433, @tuohy) * Handle bounds with `Zed.next_error` (ocaml-community/utop#442, @tmattio) * Load files from XDG directories (the legacy paths still work). (ocaml-community/utop#431, @Skyb0rg007) * Remove deprecated values `prompt_continue`, `prompt_comment`, `smart_accept`, `new_prompt_hooks`, `at_new_prompt` (#..., @emillon) * Require OCaml 4.11.0 or newer. (ocaml-community/utop#444, @emillon)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #433 for how the problem showed itself.
In 4.14 the behavior of Toploop.use_silently changed. Previously, the empty string would be interpreted as a request for Stdin. Now File and Stdin are different constructors of Toploop.input.
This PR adds logic to the wrapper already used to use the File constructor to select Stdin when the filename passed is the empty string.
NB this means that
utop -stdinworks bututop ""has the same effect, which AFAICT was the behavior pre-4.14 but may not be desirable.