Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: add outputs for each supported ocaml version #34

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Alizter
Copy link
Contributor

@Alizter Alizter commented Dec 1, 2023

This let's us do nix build .#fiber_4_09. CI PR will follow this one.

Flakes unfortunately have this somewhat artificial restriction of only allowing "flake-like" values as inputs, meaning we can't parameterize the flake by arbitrary values. One way to get around that restriction is to create some local flakes for each OCaml version. I just opted for the simpler solution of adding the appropriate flake outputs.

Not all of them build however, as there are issues in the test suite for 4.09 for example. We can investigate that (and others) after this PR.

@Alizter Alizter force-pushed the ps/branch/nix__add_outputs_for_each_supported_ocaml_version branch 4 times, most recently from 8f6d6e5 to 1383b17 Compare December 1, 2023 02:03
@Alizter
Copy link
Contributor Author

Alizter commented Dec 1, 2023

Due to the way the devShell was setup, all the packages were being added as buildInputs. I've now restricted it to the two packages it was before.

@rgrinberg
Copy link
Contributor

Can you include the CI here? I don't know how to use any of this stuff so the only value is the CI

Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter Alizter force-pushed the ps/branch/nix__add_outputs_for_each_supported_ocaml_version branch from 1383b17 to 1a369e9 Compare December 2, 2023 01:21
@Alizter
Copy link
Contributor Author

Alizter commented Dec 2, 2023

Here is the CI commits. Some further questions:

  1. Do you want a different GH job for each version?
  2. Do you want to restrict which versions we test? We are currently testing each version 4.08-5.1.
  3. This won't be ready to merge until we fix some tests that don't work on <4.11. Should I ignore those versions?

@anmonteiro
Copy link
Collaborator

I believe an overlay approach would be a bit more lightweight ocaml/ocaml-lsp#1231

@rgrinberg
Copy link
Contributor

rgrinberg commented Mar 31, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants