-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nix: add outputs for each supported ocaml version #34
Open
Alizter
wants to merge
3
commits into
ocaml-dune:main
Choose a base branch
from
Alizter:ps/branch/nix__add_outputs_for_each_supported_ocaml_version
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
nix: add outputs for each supported ocaml version #34
Alizter
wants to merge
3
commits into
ocaml-dune:main
from
Alizter:ps/branch/nix__add_outputs_for_each_supported_ocaml_version
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
force-pushed
the
ps/branch/nix__add_outputs_for_each_supported_ocaml_version
branch
4 times, most recently
from
December 1, 2023 02:03
8f6d6e5
to
1383b17
Compare
Due to the way the devShell was setup, all the packages were being added as buildInputs. I've now restricted it to the two packages it was before. |
Can you include the CI here? I don't know how to use any of this stuff so the only value is the CI |
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
ps/branch/nix__add_outputs_for_each_supported_ocaml_version
branch
from
December 2, 2023 01:21
1383b17
to
1a369e9
Compare
Here is the CI commits. Some further questions:
|
I believe an overlay approach would be a bit more lightweight ocaml/ocaml-lsp#1231 |
Sure, doing it with overlays sounds good to me. Could you send a PR?
… On Mar 30, 2024, at 10:59 PM, Antonio Nuno Monteiro ***@***.***> wrote:
I believe an overlay approach would be a bit more lightweight ocaml/ocaml-lsp#1231 <ocaml/ocaml-lsp#1231>
—
Reply to this email directly, view it on GitHub <#34 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABB56ZBPLWWBFEMU7A5MKLY247UXAVCNFSM6AAAAABACDFRAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYGQ4DSMZTGQ>.
You are receiving this because you commented.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This let's us do
nix build .#fiber_4_09
. CI PR will follow this one.Flakes unfortunately have this somewhat artificial restriction of only allowing "flake-like" values as inputs, meaning we can't parameterize the flake by arbitrary values. One way to get around that restriction is to create some local flakes for each OCaml version. I just opted for the simpler solution of adding the appropriate flake outputs.
Not all of them build however, as there are issues in the test suite for 4.09 for example. We can investigate that (and others) after this PR.