Account for stack differences in the socketpair test (issue #312) #313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux returns ECONNRESET while every other stack tested returns EOF on this test.
I did not dig into the especification but Linux appears to be on the weird side.
In order to get a ECONNRESET, the write needs to hit the socket after the close, but our program does:
WRITE(A)
CLOSE(B)
READ(A)
Linux never gives "A" side a chance to see a proper EOF, while the others do:
Linux -> ECONNRESET
FreeBSD 12 -> EOF
OpenBSD 7.2 -> EOF
macos 12.5.1 -> EOF
We can fix this by properly draining B side of things before the close, but we can't reliably test ECONNRESET so turn this into an EOF test for now.