Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib_linux: expose log src #392

Closed
wants to merge 1 commit into from

Conversation

bikallem
Copy link
Contributor

Expose log source so that we can individually control log level.

Related to mirleft/ocaml-tls#461

@bikallem
Copy link
Contributor Author

@talex5 if you don't have any objections, could we merge this as it would make debugging a bit more productive. Thanks.

@talex5
Copy link
Collaborator

talex5 commented Dec 21, 2022

I wonder if we should just get rid of all the debug logging in Eio_linux. Do you find it useful for anything?

@bikallem
Copy link
Contributor Author

I have found them to be somewhat useful, sometimes. Perhaps, leave them until 1.0? In any case, until they are completely removed, I would like to be able to control log levels to control log noise so that such debugging sessions are a bit more manageable and productive.

@avsm
Copy link
Contributor

avsm commented Dec 24, 2022

I'd prefer to reduce the dependency cone and get rid of the Logs. When I need debug logging in the backend, I'm just putting in whatever I need. It's rarely useful to turn on the backend specific logging as part of a bigger application (which is the point of the Logs library).

@talex5 talex5 mentioned this pull request Jan 6, 2023
@bikallem
Copy link
Contributor Author

bikallem commented Jan 6, 2023

closing this PR since #403 supersedes it.

@bikallem bikallem closed this Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants