Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special case for the epel-release yum-package #77

Merged
merged 3 commits into from
Oct 17, 2017

Conversation

smondet
Copy link
Contributor

@smondet smondet commented Aug 29, 2017

Fixes #70, (cf. also #76).

Tested with hdf5:

 $ docker run -it  ocaml/opam:centos-7_ocaml-4.03.0 bash
 $ opam pin add depext 'https://github.com/smondet/opam-depext.git#epel-release-special-case'
...
 $ opam depext --version
1.0.5+dev
 $ opam depext --yes hdf5
...
 $ opam installl --yes hdf5
...

@smondet smondet changed the title Special case for epel-release package Special case for the epel-release yum-package Aug 29, 2017
@avsm
Copy link
Contributor

avsm commented Sep 1, 2017

I don't mind special-casing epel, but isn't this patch doing so unconditionally? I was thinking that something like centos:epel as an additional tag might be appropriate, so that we can search for it in the list for the package and add the epel repository on demand.

@UnixJunkie
Copy link

nice hack

@smondet
Copy link
Contributor Author

smondet commented Sep 1, 2017

@avsm I did it like this because that's what seems to be already in use the
opam-repo. People specify the epel-release package when they need it (which
usually means that the depext error msg is good enough for CentOS interactive
users to fix it), like:

 [["centos"] ["epel-release" "hdf5-devel"]]

Cf. https://github.com/ocaml/opam-repository/search?utf8=%E2%9C%93&q=epel-release&type=

To pass CI builds, there is this “run some script from the internet” solution also:
ocaml/opam-repository@24ae1fb

  [["source" "centos"] ["https://gist.githubusercontent.com/akabe/9352e05d2413ccbefb2b52ea6ae81599/raw/7ad60a2be120849341cd7c5bf14656773cb7d405/centos-zmq.sh"]]

How do you think the depexp entry should look like?

 [["centos" "epel"] ["hdf5-devel"]]

or

 [["centos:epel"] ["hdf5-devel"]]

@UnixJunkie
Copy link

I personaly like the centos:epel one

@smondet
Copy link
Contributor Author

smondet commented Oct 6, 2017

@avsm any idea to move forward with this?
If you prefer any other definition than [["centos"] ["epel-release" "hdf5-devel"]] (the current one in the opam-repo), just say so :)

@AltGr
Copy link
Contributor

AltGr commented Oct 17, 2017

I am not sure what to do with this with the current redifinition of depexts: ocaml/opam#3074 , and especially the replacement for the "tags" here: ocaml/opam#3058.

The patch as is would still actually work still, and may be the simplest solution!

@avsm
Copy link
Contributor

avsm commented Oct 17, 2017

This is ok by me; it just prioritises the epel package installation. A note in the README about how to specify the use of epel in centos depexts would be good. @AltGr says he'll merge this in the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants