Support dep variables and 2.0.0~beta5 command-line format #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not backwards compatible. The system analysis and generation of the variable is done according to ocaml/opam#3058 (https://gist.github.com/AltGr/5bfc8cea6f01e74b95de79ceaba39369), but is intended to be moved to opam at some point. When that happens, this tool will be limited to handling the various package managers, deciding from the opam variables using e.g. `opam var os-distribution`. Note that this drops support for "source" tags, which aren't supported by beta5 anymore.
Merged
avsm
reviewed
Nov 6, 2017
| | "linux" -> | ||
| (String.lowercase @@ | ||
| try android_release () with Failure _ -> | ||
| try command_output "lsb_release -s -r" with Failure _ -> |
There was a problem hiding this comment.
This lsb_release needs to redirect stderr, or else you get lsb_release: command not found on (e.g.) Alpine
|
Going to merge this soon and work on the remaining problems in trunk... |
Closed
|
This got pushed directly (or otherwise merged in 23abbd0) a loooooong time ago |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not backwards compatible. The system analysis and generation of the
variable is done according to ocaml/opam#3058
(https://gist.github.com/AltGr/5bfc8cea6f01e74b95de79ceaba39369), but is
intended to be moved to opam at some point.
When that happens, this tool will be limited to handling the various package
managers, deciding from the opam variables using e.g.
opam var os-distribution.Note that this drops support for "source" tags, which aren't supported by
beta5 anymore.