Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency on dune #1330

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Fix dependency on dune #1330

merged 1 commit into from
Apr 10, 2020

Conversation

ejgallego
Copy link
Contributor

ocamlformat depends on (using menhir 2.1) which in turn requires
Dune >= 2.2.0

@ejgallego
[ocamlformat] Fix dependency on dune
c639c0c 
`ocamlformat` depends on `(using menhir 2.1)` which in turn requires
Dune >= 2.2.0
@facebook-github-bot
Copy link

Hi @ejgallego!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@ejgallego ejgallego mentioned this pull request Apr 10, 2020
Merged
@ejgallego
Copy link
Contributor Author

please sign at https://code.facebook.com/cla

oh là là , how did such a CLA end in the ocaml-ppx namespace?

@gpetiot gpetiot changed the title [ocamlformat] Fix dependency on dune Fix dependency on dune Apr 10, 2020
gpetiot
gpetiot approved these changes Apr 10, 2020
View reviewed changes
Copy link
Collaborator

@gpetiot gpetiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@gpetiot gpetiot merged commit b7b347a into ocaml-ppx:master Apr 10, 2020
@kit-ty-kate
Copy link
Contributor

Can this also be updated in the dune-project file? Starting from dune 2.5.0 (soon to be released ocaml/opam-repository#16170) this issue has been fixed and such a mistake will become a warning/error anyway. Just to give you heads up.

@ejgallego ejgallego deleted the ocamlformat_014_fix branch April 10, 2020 18:13
emillon added a commit to emillon/ocamlformat that referenced this pull request Apr 24, 2020
@emillon
Fix dune 2.5 warning relative to menhir 2.1
d1a1fcc 
`(using menhir 2.1)` implies `dune >= 2.2.0` (see ocaml-ppx#1330).
Starting with dune 2.5.0, this triggers a warning.
Using `(lang dune 2.2)` in the main project ensures consistent metadata.
@emillon emillon mentioned this pull request Apr 24, 2020
Merged
emillon added a commit that referenced this pull request Apr 24, 2020
@emillon
Fix dune 2.5 warning relative to menhir 2.1 (#1353)
0e46fb2 
`(using menhir 2.1)` implies `dune >= 2.2.0` (see #1330).
Starting with dune 2.5.0, this triggers a warning.
Using `(lang dune 2.2)` in the main project ensures consistent metadata.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpetiot gpetiot gpetiot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ejgallego @facebook-github-bot @kit-ty-kate @gpetiot