ppxlib 0.27 compatibility #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitag-ha
approved these changes
Jun 28, 2022
src/ppx_deriving_yojson.ml
Outdated
| @@ -437,7 +437,7 @@ let ser_str_of_type ~options ~path ({ ptype_loc = loc } as type_decl) = | |||
| ~attrs:[disable_warning_39 ()] | |||
| (Pat.constraint_ var poly_type) | |||
| (polymorphize [%expr ([%e sanitize ~quoter serializer])])], | |||
| [Str.value Nonrecursive [Vb.mk [%expr [%e pvar "_"]] [%expr [%e evar var_s]]] ] | |||
| [Str.value Nonrecursive [Vb.mk [%pat? [%p pvar "_"]] [%expr [%e evar var_s]]] ] | |||
There was a problem hiding this comment.
Suggested change
| [Str.value Nonrecursive [Vb.mk [%pat? [%p pvar "_"]] [%expr [%e evar var_s]]] ] | |
| [Str.value Nonrecursive [Vb.mk (pvar "_") [%expr [%e evar var_s]]] ] |
There was a problem hiding this comment.
And similarly in the other diffs.
|
@pitag-ha you are, of course, correct. I just pushed a commit fixing your suggestions. |
|
This is obviously an improvement, so merging. Thanks @anmonteiro and @pitag-ha for your work on this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with ppxlib 0.27 and ocaml-ppx/ppxlib#344, generated code has annotations which broke this repo.