-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to OCaml 4.08+beta2 #70
Conversation
I don't understand why Travis CI is complaining, and I don't have the time to investigate. |
cc @xclerc |
@jhwoodyatt I opened a PR on your fork to fix travis: jhwoodyatt#1 |
Fix Travis and opam
all green. cc @alainfrisch @gasche (not sure who's maintaining this) |
I know I'm not, but maybe I can try to have a look later in the week if nobody has stepped up. (cc @alainfrisch @nojb @xclerc @diml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I don't have merge rights though.
It's embarrassing that I don't know how to check the list of people with merge rights (to me or to the Github interface), but it may be that only @alainfrisch is in this set. I would warmly recommend to add @nojb to it, though :-) |
I have merge rights! But I can't add more people to the repository. |
While testing the master branch on 4.08 I found a small issue -- the generated code still mentions Pervasives -- for which I propose a fix in #72. Would someone look at it and consider merging it? |
Shouldn't be this merged one already? It is pretty obvious it is good one. |
I believe metaquot is currently broken with this feature. Also see the patch in ppx_tools_versionned https://github.com/ocaml-ppx/ppx_tools_versioned/pull/22/files#diff-7ab097557bb7183454f885e4595acc38R180 |
For reference, this is what OCaml 4.08+beta2 seems to require (issue #69).