-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCaml 4.11 support #82
Conversation
Port work from Richard W.M. Jones. See ocaml-ppx#81
By
It seems that somewhere it tries to parse |
I'm afraid I don't know the answer to any of these questions either :-( |
I will have a look, but the argument of |
The source of the error is in fact the |
ocaml-ppx/ppx_tools#82 is restricted to OCaml >=4.10.
ocaml-ppx/ppx_tools#82 is restricted to OCaml >=4.10.
Who has commit rights here and can decide to merge this PR or a similar PR? I don't, and I don't actually know who does. (cc @Drup who I believe did merge a PR a while back.) |
I have, I'll make a release soon. I just wanted to deal with packages that depend on ppx_tools first |
All good now. Sorry for the delay |
Port work from @rwmjones. See #81
Here two points I'm not so sure about:
(* XXX? *)
comment there.Longident.parse x
as the proposedParse.longident (Lexing.from_string x)
does not work and fails to parse several things. @Octachron any idea?