Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCaml 4.11 support #82

Merged
merged 4 commits into from
Jul 3, 2020
Merged

OCaml 4.11 support #82

merged 4 commits into from
Jul 3, 2020

Conversation

kit-ty-kate
Copy link
Collaborator

@kit-ty-kate kit-ty-kate commented Apr 22, 2020

Port work from @rwmjones. See #81

Here two points I'm not so sure about:

  • I'm not sure what is the constant method. The original commit had a (* XXX? *) comment there.
  • I'm not sure what to use instead of the deprecated Longident.parse x as the proposed Parse.longident (Lexing.from_string x) does not work and fails to parse several things. @Octachron any idea?

@kit-ty-kate
Copy link
Collaborator Author

By weird error messagefails to parse several things, I meant mainly:

File "dumpast.ml", line 35, characters 12-33:
35 |     inherit [_] Ast_lifter.lifter as super
                 ^^^^^^^^^^^^^^^^^^^^^
Error: Unbound class Ast_lifter.lifter

It seems that somewhere it tries to parse [_] Ast_lifter.lifter, and only Longident.parse is able to parse this successfully.

@rwmjones
Copy link

I'm afraid I don't know the answer to any of these questions either :-(

@Octachron
Copy link

Octachron commented Apr 22, 2020

I will have a look, but the argument of inherit is a class expression, trying to parse it as a Longident is bound to fail.

@Octachron
Copy link

Octachron commented Apr 22, 2020

The source of the error is in fact the cons functions in ast_convenience that are using the internal name "::" for the constructor (::).

ast_convenience.ml Outdated Show resolved Hide resolved
ast_mapper_class.ml Outdated Show resolved Hide resolved
thierry-martinez added a commit to thierry-martinez/ppx_deriving that referenced this pull request May 23, 2020
thierry-martinez added a commit to thierry-martinez/ppx_deriving that referenced this pull request May 23, 2020
thierry-martinez added a commit to thierry-martinez/ppx_deriving that referenced this pull request May 23, 2020
@gasche
Copy link
Contributor

gasche commented May 25, 2020

Who has commit rights here and can decide to merge this PR or a similar PR? I don't, and I don't actually know who does. (cc @Drup who I believe did merge a PR a while back.)

@kit-ty-kate
Copy link
Collaborator Author

kit-ty-kate commented May 25, 2020

I have, I'll make a release soon. I just wanted to deal with packages that depend on ppx_tools first

@kit-ty-kate kit-ty-kate marked this pull request as ready for review July 3, 2020 14:47
@kit-ty-kate
Copy link
Collaborator Author

All good now. Sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants