Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA workflow #38

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Add GHA workflow #38

merged 4 commits into from
Oct 13, 2023

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Jul 21, 2023

@erikmd erikmd force-pushed the gha branch 7 times, most recently from 76b4659 to 229517a Compare July 21, 2023 09:01
@erikmd
Copy link
Member Author

erikmd commented Jul 21, 2023

@yurug and @AltGr

I added a GitHub Actions workflow in learn-ocaml-corpus as requested at our last meeting.

Good news! → the learn-ocaml-corpus successfully builds from source with all versions of learn-ocaml from 0.12:
namely, the workflow tests {0.12,0.13.1,0.14.1,master}.

Downside: the 0.12 test is significantly slower (23' > 2'), and requires a workaround to overcome an old bug (ocaml-sf/learn-ocaml#305).

I don't know exactly why the 0.12 build is so slow.

Anyway, what solution do you vote for?

  1. Keep this PR as is, testing 0.12 likewise for the master branch and each PR test
  2. Keep this PR almost as is, but disable 0.12 testing on pull_request to earn time (while keeping the ability to trigger it manually)
  3. Drop 0.12 testing in learn-ocaml-corpus, and drop 0.12 compatibility in learn-ocaml

AFAIAC, I'd be equally up for 1. or 2., considering that we can switch to solution 3. anytime…

WDYT?

@erikmd
Copy link
Member Author

erikmd commented Aug 18, 2023

@yurug just voted for option 2. as well in our last telco.

So I'll refactor the PR accordingly.

@erikmd
Copy link
Member Author

erikmd commented Oct 13, 2023

FYI @yurug, with @AltGr we decided to drop the integration test with versions < 0.15.0
because versions upto 0.14.1 did have the vuln. fixed by PR ocaml-sf/learn-ocaml#560,
hence this incentive to migrate if need be.
Of course, we'll try to keep backward-compat. for all versions ≥ 0.15.0.
I plan to fix this PR and merge it today.

Testing learn-ocaml-corpus with:

- ocamlsf/learn-ocaml:0.15.0
- ocamlsf/learn-ocaml:master
It was only needed for learn-ocaml v0.12
@erikmd erikmd self-assigned this Oct 13, 2023
@erikmd
Copy link
Member Author

erikmd commented Oct 13, 2023

The CI just approved ✔️, so as promised, let's merge this one

@erikmd erikmd merged commit 54a1cec into master Oct 13, 2023
2 checks passed
@erikmd erikmd deleted the gha branch October 13, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant