-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GHA workflow #38
Add GHA workflow #38
Conversation
76b4659
to
229517a
Compare
I added a GitHub Actions workflow in learn-ocaml-corpus as requested at our last meeting. Good news! → the learn-ocaml-corpus successfully builds from source with all versions of learn-ocaml from 0.12: Downside: the 0.12 test is significantly slower (23' > 2'), and requires a workaround to overcome an old bug (ocaml-sf/learn-ocaml#305). I don't know exactly why the 0.12 build is so slow. Anyway, what solution do you vote for?
AFAIAC, I'd be equally up for 1. or 2., considering that we can switch to solution 3. anytime… WDYT? |
@yurug just voted for option 2. as well in our last telco. So I'll refactor the PR accordingly. |
FYI @yurug, with @AltGr we decided to drop the integration test with versions < 0.15.0 |
Testing learn-ocaml-corpus with: - ocamlsf/learn-ocaml:0.15.0 - ocamlsf/learn-ocaml:master
It was only needed for learn-ocaml v0.12
The CI just approved ✔️, so as promised, let's merge this one |
FYI @yurug @AltGr