fix: update overrideURL to handle escape characters problems in URL

ocaml-sf · May 18, 2021 · 1e87190 · 1e87190
1 parent 2b071d1
commit 1e87190
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/repo/learnocaml_exercise.ml b/src/repo/learnocaml_exercise.ml
@@ -324,11 +324,13 @@ module File = struct
            None
          else
            let title_url =
-             if title <> "" then Printf.sprintf {| title="%s"|} title else "" in
+             if title <> "" then Printf.sprintf {| title="%s"|}
+                               (Omd_utils.htmlentities ~md:true title) else "" in
            let html =
              Printf.sprintf
               {|<a href="%s" target="_blank" rel="noopener noreferrer"%s>%s</a>|}
-              href title_url (Omd_backend.html_of_md s) in
+              (Omd_utils.htmlentities ~md:true href) title_url
+                 (Omd_backend.html_of_md s) in
            Some html
          else None
     | _ -> None in