feat: Add CLI option `learn-ocaml build --build-dir=[./_learn-ocaml-b…

…uild]` (#585)

Motivation:
- in current master, the exercises were always precompiled in-place;
- this conflicted with the documented workflow (option "ro"):
  - https://ocaml-sf.org/learn-ocaml/howto-deploy-a-learn-ocaml-instance.html
  - https://ocaml-sf.org/learn-ocaml/howto-setup-exercise-development-environment.html
- this new option makes it possible to copy and precompile exercises apart by default
  (in the ./_learn-ocaml-build/exercises subdirectory, which is erased before the build).

Examples:
- `learn-ocaml build --repo=demo-repository`
- `learn-ocaml build --repo=demo-repository serve`
- `learn-ocaml build --repo=demo-repository serve --replace`
  # or
- `learn-ocaml build --repo=demo-repository --build-dir=demo-repository`
  # to retrieve the previous behavior of learn-ocaml master.

Note: externalizing the build-dir in a volume looks unneeded:
if the build-dir is shared, but the container is deleted,
the www is deleted as well, and the exercices are rebuilt anyway
and an extra volume would add more noise (mandating `-v args` tweaks)

src/main/learnocaml_main.ml

@@ -24,6 +24,14 @@ let readlink f =
   try Sys.chdir cwd; f
   with Sys_error _ -> Sys.chdir (Filename.get_temp_dir_name ()); f
 
+let absolute_filename path =
+  (* Note: symlinks are not taken into account *)
+  if Filename.is_relative path
+  then Filename.concat (Sys.getcwd ()) path
+  else path
+
+let dflt_build_dir = "_learn-ocaml-build"
+
 module Args = struct
   open Arg
 
@@ -44,6 +52,16 @@ module Args = struct
       "The path to the repository containing the exercises, lessons and \
        tutorials."
 
+  let build_dir =
+    value & opt dir ("./" ^ dflt_build_dir) & info ["build-dir"] ~docs ~docv:"DIR" ~doc:
+    (Printf.sprintf
+       "Directory where the repo exercises are copied and precompiled. \
+        When $(docv) takes its default value (e.g. when it is omitted in CLI), \
+        '$(b,learn-ocaml build)' first erases the '$(docv)/exercises' subfolder. \
+        Note that the default value for $(docv), './%s', is generally a sensible choice. \
+        But passing the same argument as the one for $(i,--repo) is also a valid value for $(docv)."
+     dflt_build_dir)
+
   let app_dir =
     value & opt string "./www" & info ["app-dir"; "o"] ~docs ~docv:"DIR" ~doc:
       "Directory where the app should be generated for the $(i,build) command, \
@@ -215,9 +233,10 @@ module Args = struct
       Term.(const apply $contents_dir $try_ocaml $lessons $exercises $playground $toplevel $base_url)
 
     let repo_conf =
-      let apply repo_dir exercises_filtered jobs =
+      let apply repo_dir build_dir exercises_filtered jobs =
         Learnocaml_process_exercise_repository.exercises_dir :=
-          repo_dir/"exercises";
+          (* not repo_dir/"exercises" here - since we need write permissions *)
+          build_dir/"exercises";
         Learnocaml_process_exercise_repository.exercises_filtered :=
           Learnocaml_data.SSet.of_list (List.flatten exercises_filtered);
         Learnocaml_process_tutorial_repository.tutorials_dir :=
@@ -227,7 +246,7 @@ module Args = struct
         Learnocaml_process_exercise_repository.n_processes := jobs;
         ()
       in
-      Term.(const apply $repo_dir $exercises_filtered $jobs)
+      Term.(const apply $repo_dir $build_dir $exercises_filtered $jobs)
 
     let term =
       let apply conf () = conf in
@@ -243,16 +262,17 @@ module Args = struct
     commands: command list;
     app_dir: string;
     repo_dir: string;
+    build_dir: string;
     grader: Grader.t;
     builder: Builder.t;
     server: Server.t;
   }
 
   let term =
-    let apply commands app_dir repo_dir grader builder server =
-      { commands; app_dir; repo_dir; grader; builder; server }
+    let apply commands app_dir repo_dir build_dir grader builder server =
+      { commands; app_dir; repo_dir; build_dir; grader; builder; server }
     in
-    Term.(const apply $commands $app_dir $repo_dir
+    Term.(const apply $commands $app_dir $repo_dir $build_dir
           $Grader.term $Builder.term $Server.term app_dir base_url)
 end
 
@@ -328,6 +348,49 @@ let main o =
        >|= fun i -> Some i)
     else Lwt.return_none
   in
+  let copy_build_exercises o =
+    (* NOTE: if `--build` = `--repo`, then no copy is needed.
+       Before checking path equality, we need to get canonical paths *)
+    let repo_exos_dir = readlink o.repo_dir / "exercises" in
+    let build_exos_dir = readlink o.build_dir / "exercises" in
+    if repo_exos_dir <> build_exos_dir then begin
+        (* NOTE: if the CLI arg is "./_learn-ocaml-build" or "_learn-ocaml-build"
+           then the exercises subdirectory is erased beforehand *)
+        begin
+          if (o.build_dir = dflt_build_dir || o.build_dir = "./" ^ dflt_build_dir)
+             && Sys.file_exists build_exos_dir then
+            Lwt.catch (fun () ->
+                Lwt_process.exec ("rm",[|"rm";"-rf"; build_exos_dir|]) >>= fun r ->
+                if r <> Unix.WEXITED 0 then
+                  Lwt.fail_with "Remove command failed"
+                else Lwt.return_unit)
+              (fun ex ->
+                Printf.eprintf
+                  "Error: while removing previous build-dir \
+                   %s:\n    %s\n%!"
+                  build_exos_dir (Printexc.to_string ex);
+                exit 1)
+          else
+            Lwt.return_unit
+        end >>= fun () ->
+        Printf.printf "Building %s\n%!" (o.build_dir / "exercises");
+        (* NOTE: we choose to reuse Lwt_utils.copy_tree,
+           even if we could use "rsync" (upside: "--delete-delay",
+           but downside: would require the availability of rsync). *)
+        Lwt.catch
+          (fun () -> Lwt_utils.copy_tree repo_exos_dir build_exos_dir)
+          (function
+           | Failure _ ->
+              Lwt.fail_with @@ Printf.sprintf
+                                 "Failed to copy repo exercises to %s"
+                                 (build_exos_dir)
+           | e -> Lwt.fail e)
+      (* NOTE: no chown is needed,
+         but we may want to run "chmod -R u+w exercises"
+         if the source repository has bad permissions... *)
+      end
+    else Lwt.return_unit
+  in
   let generate o =
     if List.mem Build o.commands then
       (let get_app_dir o =
@@ -412,7 +475,9 @@ let main o =
          (fun _ -> Learnocaml_process_playground_repository.main (o.app_dir))
        >>= fun playground_ret ->
        if_enabled o.builder.Builder.exercises (o.repo_dir/"exercises")
-         (fun _ -> Learnocaml_process_exercise_repository.main (o.app_dir))
+         (fun _ ->
+           copy_build_exercises o >>= fun () ->
+           Learnocaml_process_exercise_repository.main (o.app_dir))
        >>= fun exercises_ret ->
        Lwt_io.with_file ~mode:Lwt_io.Output (o.app_dir/"js"/"learnocaml-config.js")
          (fun oc ->
@@ -442,11 +507,7 @@ let main o =
           let running = Learnocaml_server.check_running () in
           Option.iter Learnocaml_server.kill_running running;
           let temp = temp_app_dir o in
-          let app_dir =
-            if Filename.is_relative o.app_dir
-            then Filename.concat (Sys.getcwd ()) o.app_dir
-            else o.app_dir
-          in
+          let app_dir = absolute_filename o.app_dir in
           let bak =
             let f =
               Filename.temp_file