Bug: the Closed/Open state should appear for Assigned exercises #534
Comments
|
@AltGr I keep this issue open because it seems not yet fixed in master |
8 tasks
erikmd
added a commit
to pfitaxel/learn-ocaml
that referenced
this issue
Aug 25, 2023
* Refactor and fix "Open"/"Closed"/… display code, Put function `is_open_or_assigned_globally` in `Learnocaml_data`, returning ( GloballyOpen | GloballyOpenOrAssigned | GloballyClosedOrAssigned | GloballyClosed ) * Make invariants explicit in OCaml comments Close ocaml-sf#534 Close ocaml-sf#558
erikmd
added a commit
to pfitaxel/learn-ocaml
that referenced
this issue
Aug 25, 2023
* Refactor and fix "Open"/"Closed"/… display code, Put function `is_open_or_assigned_globally` in `Learnocaml_data`, returning ( GloballyOpen | GloballyOpenOrAssigned | GloballyClosedOrAssigned | GloballyClosed ) * Make invariants explicit in OCaml comments Close ocaml-sf#534 Close ocaml-sf#558
erikmd
added a commit
to pfitaxel/learn-ocaml
that referenced
this issue
Aug 25, 2023
* Refactor and fix "Open"/"Closed"/… display code, Put function `is_open_or_assigned_globally` in `Learnocaml_data`, returning ( GloballyOpen | GloballyOpenOrAssigned | GloballyClosedOrAssigned | GloballyClosed ) * Make invariants explicit in OCaml comments Close ocaml-sf#534 Close ocaml-sf#558
erikmd
added a commit
to pfitaxel/learn-ocaml
that referenced
this issue
Aug 28, 2023
* Refactor and fix "Open"/"Closed"/… display code * Add function `is_open_or_assigned_globally` in `Learnocaml_data` that returns ( GloballyOpen | GloballyOpenOrAssigned | GloballyClosedOrAssigned | GloballyClosed ) * Make invariants explicit in OCaml comments * Add `check…` and `fix…` functions in `Learnocaml_data.Exercise.Status` to assert if the (assignments map, default) comply with the invariants (a false result means that there is at least one Open and one Closed) Close ocaml-sf#534 Close ocaml-sf#558
erikmd
added a commit
to pfitaxel/learn-ocaml
that referenced
this issue
Aug 28, 2023
* Refactor and fix "Open"/"Closed"/… display code * Add function `is_open_or_assigned_globally` in `Learnocaml_data` that returns ( GloballyOpen | GloballyOpenOrAssigned | GloballyClosedOrAssigned | GloballyClosed ) * Make invariants explicit in OCaml comments * Add `check…` and `fix…` functions in `Learnocaml_data.Exercise.Status` to assert if the (assignments map, default) comply with the invariants (a false result means that there is at least one Open and one Closed) Close ocaml-sf#534 Close ocaml-sf#558
erikmd
added a commit
to pfitaxel/learn-ocaml
that referenced
this issue
Sep 10, 2023
* Refactor and fix "Open"/"Closed"/… display code * Add function `is_open_or_assigned_globally` in `Learnocaml_data` that returns ( GloballyOpen | GloballyOpenOrAssigned | GloballyClosedOrAssigned | GloballyClosed ) * Make invariants explicit in OCaml comments * Add `check…` and `fix…` functions in `Learnocaml_data.Exercise.Status` to assert if the (assignments map, default) comply with the invariants (a false result means that there is at least one Open and one Closed) Close ocaml-sf#534 Related: ocaml-sf#558
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related user(s):
@erikmd, @AltGr
Related issue(s) or PR(s):
No response
Related project scope(s):
teacher dashboard
Bug description:
If an exercise has at least one assigned student, the teacher dashboard displays the
Assignedstate only, while it should displayOpen AssignedorClosed Assigned, to show what the exercise status is for unassigned students.To reproduce:
No response
Expected behavior:
No response
learn-ocaml --version
No response
git describe --long --always --abbrev=40 --tags
No response
What OS do you use?
GNU/Linux
What OS version/distribution do you use?
Debian
What browser(s) do you use with learn-ocaml?
Firefox, Chromium
What browser(s) version did you used to reproduce the issue?
No response
Screenshots (if need be):
No response
Additional context:
No response
The text was updated successfully, but these errors were encountered: