Generate valid Wasm code #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure that locals are always explicitely initialized before being used - Do not declare a memory if not used
OlivierNicole
approved these changes
Feb 22, 2024
Comment on lines
+104
to
+107
| | I32 | I64 | F32 | F64 | Ref { nullable = true; _ } -> | ||
| mark_initialized ctx (i + param_count) | ||
| | Ref { nullable = false; _ } -> ()) | ||
| locals; |
There was a problem hiding this comment.
(Nit, feel free to ignore) Personally I like to explicit the ignored fields in order to have the typechecker catch all the potential locations to update when modifying a type, but I admit that it can be verbose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that locals are always explicitely initialized before being used.