Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the build for 4.02-4.04 on macOS and for 4.02-4.10 with MSVC on Windows #8

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

Fix the build for 4.02-4.04 on macOS and for 4.02-4.10 with MSVC on Windows #8

wants to merge 5 commits into from

Commits on Jul 25, 2022

  1. Use a static dune file 

    Dune doesn't allow the modules list itself to be filtered, but it is
possible to control the meaning of :standard by using (enabled_if ..)
to assemble only the desired .ml and .mli in the build directory.
    @dra27
    dra27 committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    4b419cd View commit details
    Browse the repository at this point in the history

  2. Put the flags with the code 

    Code is now in src/ with nefarious trickery reserved for the dune file
only.
    @dra27
    dra27 committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    c06ad42 View commit details
    Browse the repository at this point in the history

  3. Create an empty library on 4.13 and earlier

    @dra27
    dra27 committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    bf52a8d View commit details
    Browse the repository at this point in the history

  4. Use modern warning flags instead of numbers 

    Since these are only passed to OCaml 4.14+, we can take advantage of the
clearer symbolic names.
    @dra27
    dra27 committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    8e69b91 View commit details
    Browse the repository at this point in the history

  5. Fix linking on macOS 4.02-4.04 and MSVC 4.02-4.10 

    ocamlopt on these versions of OCaml cannot create .cmxa files with no
modules. On these versions, create a dummy CamlinternalCamlp_streams
module whose name will be assumed never to clash as it uses the
compiler's reserved prefix.
    @dra27
    dra27 committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    c9acc86 View commit details
    Browse the repository at this point in the history