Merge pull request #10671 from vouillon/expect-test-deps

Expect test fixes

doc/changes/10671.md

@@ -0,0 +1 @@
+- Expect test fixes: support multiple modes and fix dependencies when there is a custom runner (#10671, @vouillon)

src/dune_rules/test_rules.ml

@@ -1,14 +1,14 @@
 open Import
 
 let rules (t : Tests.t) ~sctx ~dir ~scope ~expander ~dir_contents =
-  let test_kind (loc, name) =
+  let test_kind (loc, name, ext) =
     let files = Dir_contents.text_files dir_contents in
     let expected_basename = name ^ ".expected" in
     if Filename.Set.mem files expected_basename
     then
       `Expect
         { Diff.file1 = String_with_vars.make_text loc expected_basename
-        ; file2 = String_with_vars.make_text loc (name ^ ".output")
+        ; file2 = String_with_vars.make_text loc (name ^ ext ^ ".output")
         ; optional = false
         ; mode = Text
         }
@@ -70,32 +70,33 @@ let rules (t : Tests.t) ~sctx ~dir ~scope ~expander ~dir_contents =
           | `js -> Jsoo_rules.js_of_ocaml_runtest_alias ~dir
           | `exe | `bc -> Memo.return Alias0.runtest
         in
+        let deps =
+          match custom_runner with
+          | Some _ ->
+            Bindings.Unnamed (Dep_conf.File (String_with_vars.make_text loc test_exe))
+            :: t.deps
+          | None -> t.deps
+        in
         let add_alias ~loc ~action ~locks =
           (* CR-rgrinberg: why are we going through the stanza api? *)
           let alias =
             { Alias_conf.name = runtest_alias
             ; locks
             ; package = t.package
-            ; deps =
-                (match custom_runner with
-                 | Some _ ->
-                   Bindings.Unnamed
-                     (Dep_conf.File (String_with_vars.make_text loc test_exe))
-                   :: t.deps
-                 | None -> t.deps)
+            ; deps
             ; action = Some (loc, action)
             ; enabled_if = t.enabled_if
             ; loc
             }
           in
           Simple_rules.alias sctx ~extra_bindings ~dir ~expander alias
         in
-        match test_kind (loc, s) with
+        match test_kind (loc, s, ext) with
         | `Regular -> add_alias ~loc ~action:run_action ~locks:[]
         | `Expect diff ->
           let rule =
             { Rule_conf.targets = Infer
-            ; deps = t.deps
+            ; deps
             ; action =
                 ( loc
                 , Action_unexpanded.Redirect_out (Stdout, diff.file2, Normal, run_action)

test/blackbox-tests/test-cases/jsoo/tests.t/b.expected

@@ -0,0 +1 @@
+b: ok

test/blackbox-tests/test-cases/jsoo/tests.t/run.t

@@ -2,4 +2,3 @@ tests stanza with jsoo
 
   $ dune build @default @runtest-js
   a: ok
-  b: ok

test/blackbox-tests/test-cases/tests-stanza-expected-deps.t

@@ -23,4 +23,4 @@ This is visible when trying to build the `@all` alias. See #5950.
 
   $ cp data.txt t.expected
 
-  $ dune build t.output
+  $ dune build t.exe.output

test/blackbox-tests/test-cases/tests-stanza/generated.t/run.t

@@ -1,5 +1,5 @@
   $ dune runtest
   File "generated.expected", line 1, characters 0-0:
   Error: Files _build/default/generated.expected and
-  _build/default/generated.output differ.
+  _build/default/generated.exe.output differ.
   [1]

test/blackbox-tests/test-cases/tests-stanza/modes.t/dune

@@ -0,0 +1 @@
+(test (name modes) (modes byte native))

test/blackbox-tests/test-cases/tests-stanza/modes.t/dune-project

@@ -0,0 +1 @@
+(lang dune 3.0)

test/blackbox-tests/test-cases/tests-stanza/modes.t/modes.expected

@@ -0,0 +1 @@
+testing multiple modes

test/blackbox-tests/test-cases/tests-stanza/modes.t/modes.ml

@@ -0,0 +1 @@
+print_endline "testing multiple modes"

test/blackbox-tests/test-cases/tests-stanza/modes.t/run.t

@@ -0,0 +1 @@
+  $ dune runtest