Fix #3347

Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
ocaml · Apr 9, 2020 · 6e6488a · 6e6488a
1 parent a64da01
commit 6e6488a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -48,6 +48,9 @@ Unreleased
 - Add a `(subdir ..)` stanza to allow evaluating stanzas in sub directories.
   (#3268, @rgrinberg)
 
+- Fix a bug preventing one from running inline tests in multiple modes
+  (#3348, @diml)
+
 2.4.0 (06/03/2020)
 ------------------
 

diff --git a/src/dune/inline_tests.ml b/src/dune/inline_tests.ml
@@ -334,7 +334,7 @@ include Sub_system.Register_end_point (struct
           | Javascript -> Some "node"
         in
         SC.add_alias_action sctx ~dir ~loc:(Some info.loc) (Alias.runtest ~dir)
-          ~stamp:("ppx-runner", name)
+          ~stamp:("ppx-runner", name, mode)
           (let exe =
              Path.build (Path.Build.relative inline_test_dir (name ^ ext))
            in

diff --git a/test/blackbox-tests/test-cases/inline_tests-multi-mode/run.t b/test/blackbox-tests/test-cases/inline_tests-multi-mode/run.t
@@ -29,8 +29,7 @@ Reproduction case for #3347
   $ touch test.ml
 
   $ dune runtest
-  Error: Multiple rules generated for
-  _build/.aliases/default/runtest-35bbbc336be45723611745d39daa46eb:
-  - dune:5
-  - dune:5
-  [1]
+           run alias runtest
+  Test byte
+           run alias runtest
+  Test native