refactor: use Path.External.t for dump_memo_graph_file (#8117)

Signed-off-by: Ali Caglayan <alizter@gmail.com>
ocaml · Jul 5, 2023 · bb06683 · bb06683
1 parent 156bd68
commit bb06683
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/bin/build_cmd.ml b/bin/build_cmd.ml
@@ -59,7 +59,7 @@ let run_build_system ~common ~request =
         match Common.dump_memo_graph_file common with
         | None -> Fiber.return ()
         | Some file ->
-          let path = Path.of_filename_relative_to_initial_cwd file in
+          let path = Path.external_ file in
           let+ graph =
             Memo.dump_cached_graph
               ~time_nodes:(Common.dump_memo_graph_with_timing common)

diff --git a/bin/common.ml b/bin/common.ml
@@ -531,7 +531,7 @@ module Builder = struct
     ; default_target : Arg.Dep.t (* For build & runtest only *)
     ; watch : Dune_rpc_impl.Watch_mode_config.t
     ; print_metrics : bool
-    ; dump_memo_graph_file : string option
+    ; dump_memo_graph_file : Path.External.t option
     ; dump_memo_graph_format : Graph.File_format.t
     ; dump_memo_graph_with_timing : bool
     ; dump_gc_stats : Path.External.t option
@@ -899,7 +899,9 @@ module Builder = struct
     ; default_target
     ; watch
     ; print_metrics
-    ; dump_memo_graph_file
+    ; dump_memo_graph_file =
+        Option.map dump_memo_graph_file
+          ~f:Path.External.of_filename_relative_to_initial_cwd
     ; dump_memo_graph_format
     ; dump_memo_graph_with_timing
     ; dump_gc_stats =

diff --git a/bin/common.mli b/bin/common.mli
@@ -27,7 +27,7 @@ val stats : t -> Dune_stats.t option
 
 val print_metrics : t -> bool
 
-val dump_memo_graph_file : t -> string option
+val dump_memo_graph_file : t -> Path.External.t option
 
 val dump_memo_graph_format : t -> Dune_graph.Graph.File_format.t