Skip to content

Commit

Permalink
Make no_keep_locs fatal for >= 2.0
Browse files Browse the repository at this point in the history
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
  • Loading branch information
rgrinberg committed Oct 15, 2019
1 parent ada6596 commit e4fa6eb
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/dune/dune_file.ml
Original file line number Diff line number Diff line change
Expand Up @@ -865,8 +865,11 @@ module Library = struct
and+ no_dynlink = field_b "no_dynlink"
and+ () =
let check =
let+ loc = loc in
User_warning.emit ~loc
let+ loc = loc
and+ dune_version = Dune_lang.Syntax.get_exn Stanza.syntax
in
let is_error = dune_version >= (2, 0) in
User_warning.emit ~loc ~is_error
[ Pp.text "no_keep_locs is a no-op. Please delete it." ]
in
let+ _ = field_b "no_keep_locs" ~check in
Expand Down

0 comments on commit e4fa6eb

Please sign in to comment.