-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDX does not rebuild when the prelude changes #7077
Closed
Comments
Confirmed from a quick look at the source code. I'll prepare a PR. |
talex5
added a commit
to talex5/eio
that referenced
this issue
Feb 15, 2023
Work-around for ocaml/dune#7077.
emillon
added a commit
to emillon/dune
that referenced
this issue
Feb 17, 2023
When mdx is used in program-generation mode (version >= 0.2), the paths used as preludes are recorded in the executable, but the contents of files are only read when the program is executed. This adds the missing dependencies. Fixes ocaml#7077 Signed-off-by: Etienne Millon <me@emillon.org>
emillon
added a commit
to emillon/dune
that referenced
this issue
Feb 20, 2023
When mdx is used in program-generation mode (version >= 0.2), the paths used as preludes are recorded in the executable, but the contents of files are only read when the program is executed. This adds the missing dependencies. Fixes ocaml#7077 Signed-off-by: Etienne Millon <me@emillon.org>
emillon
added a commit
that referenced
this issue
Feb 20, 2023
When mdx is used in program-generation mode (version >= 0.2), the paths used as preludes are recorded in the executable, but the contents of files are only read when the program is executed. This adds the missing dependencies. Fixes #7077 Signed-off-by: Etienne Millon <me@emillon.org>
emillon
added a commit
to emillon/dune
that referenced
this issue
Mar 30, 2023
When mdx is used in program-generation mode (version >= 0.2), the paths used as preludes are recorded in the executable, but the contents of files are only read when the program is executed. This adds the missing dependencies. Fixes ocaml#7077 Signed-off-by: Etienne Millon <me@emillon.org>
emillon
added a commit
to emillon/dune
that referenced
this issue
Mar 31, 2023
When mdx is used in program-generation mode (version >= 0.2), the paths used as preludes are recorded in the executable, but the contents of files are only read when the program is executed. This adds the missing dependencies. Fixes ocaml#7077 Signed-off-by: Etienne Millon <me@emillon.org>
emillon
added a commit
that referenced
this issue
Apr 3, 2023
When mdx is used in program-generation mode (version >= 0.2), the paths used as preludes are recorded in the executable, but the contents of files are only read when the program is executed. This adds the missing dependencies. Fixes #7077 Signed-off-by: Etienne Millon <me@emillon.org>
moyodiallo
pushed a commit
to moyodiallo/dune
that referenced
this issue
Apr 3, 2023
When mdx is used in program-generation mode (version >= 0.2), the paths used as preludes are recorded in the executable, but the contents of files are only read when the program is executed. This adds the missing dependencies. Fixes ocaml#7077 Signed-off-by: Etienne Millon <me@emillon.org>
emillon
added a commit
to emillon/opam-repository
that referenced
this issue
Apr 4, 2023
…, dune-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info, dune-action-plugin and chrome-trace (3.7.1) CHANGES: - Fix segfault on MacOS when dune was being shutdown while in watch mode. (ocaml/dune#7312, fixes ocaml/dune#6151, @gridbugs, @emillon) - Fix preludes not being recorded as dependencies in the `(mdx)` stanza (ocaml/dune#7109, fixes ocaml/dune#7077, @emillon). - Pass correct flags when compiling `stdlib.ml`. (ocaml/dune#7241, @emillon) - Handle "Too many links" errors when using Dune cache on Windows. The fix in 3.7.0 for this same issue was not effective due to a typo. (ocaml/dune#7472, @nojb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
When using
(mdx (preludes prelude.ml) ...)
, changingprelude.ml
should cause the tests to be run again.Actual Behavior
It ignores this and you have to do
dune clean
first.Reproduction
Specifications
dune
(output ofdune --version
): 3.6.2ocaml
(output ofocamlc --version
): 5.0.0The text was updated successfully, but these errors were encountered: