Dune init's --public doesn't allow dashes

[reynir]

Expected Behavior

Dune init's --public can take names with dashes in them.

Actual Behavior

An error explaining only characters [a-zA-Z0-9_] are allowed.

Reproduction

$ dune init lib mirage_pair --public mirage-pair
dune: option '--public': invalid component name `mirage-pair'
      Library names must be non-empty and composed only of the
      following
      characters: 'A'..'Z', 'a'..'z', '_' or '0'..'9'.
Usage: dune init library [OPTION]… NAME [PATH]
Try 'dune init library --help' or 'dune --help' for more information.

Specifications

• Version of dune (output of dune --version): 3.6.1
• Version of ocaml (output of ocamlc --version) 4.14.0
• Operating system (distribution and version): debian 11.6

[Alizter]

Does putting it in quotations work?

[reynir]

Sorry how do you mean?

[Alizter]

I mean

dune init lib mirage_pair --public "mirage-pair"

[reynir]

No, that does the same.

[reynir]

The relevant code is here:

dune/bin/init.ml

Lines 16 to 48 in d3d628f

	let component_name_parser s =
	(* TODO refactor to use Lib_name.Local.conv *)
	let err_msg () =
	User_error.make
	[ Pp.textf "invalid component name `%s'" s
	; Lib_name.Local.valid_format_doc
	]
	|> User_message.to_string
	|> fun m -> `Msg m
	in
	let open Result.O in
	let* atom = atom_parser s in
	let* _ =
	match Lib_name.Local.of_string_opt s with
	| None -> Error (err_msg ())
	| Some s -> Ok s
	in
	Ok atom
	let atom_conv = Arg.conv (atom_parser, atom_printer)
	let component_name_conv = Arg.conv (component_name_parser, atom_printer)
	let public_name_conv =
	let open Component.Options in
	let parser = function
	| "" -> Ok Use_name
	| s -> component_name_parser s |> Result.map ~f:(fun a -> Public_name a)
	in
	let printer ppf public_name =
	Format.pp_print_string ppf (public_name_to_string public_name)
	in
	Arg.conv (parser, printer)

The problem is the same converter for library names is used for the public library name. It uses Lib_name.Local

dune/src/dune_rules/lib_name.ml

Lines 17 to 19 in d3d628f

	let valid_char = function
	| 'A' .. 'Z' | 'a' .. 'z' | '_' | '0' .. '9' -> true
	| _ -> false

I'm unsure if there's existing code that can be used for the public name or how to go forward on this.

[PizieDust]

currently having this issue too