-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: demonstrate overflow with sendfile #10334
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
reviewed
Mar 29, 2024
ok so actually truncate makes a sparse file, but |
See ocaml#10333 Signed-off-by: Etienne Millon <me@emillon.org>
emillon
force-pushed
the
test-sendfile-overflow
branch
from
April 2, 2024 08:26
70e81c4
to
0825e64
Compare
pmwhite
pushed a commit
to pmwhite/dune
that referenced
this pull request
Apr 2, 2024
See ocaml#10333 Signed-off-by: Etienne Millon <me@emillon.org>
emillon
added a commit
to emillon/dune
that referenced
this pull request
Apr 17, 2024
See ocaml#10333 Signed-off-by: Etienne Millon <me@emillon.org>
emillon
added a commit
to emillon/dune
that referenced
this pull request
Apr 17, 2024
See ocaml#10333 Signed-off-by: Etienne Millon <me@emillon.org>
emillon
added a commit
to emillon/dune
that referenced
this pull request
Apr 17, 2024
See ocaml#10333 Signed-off-by: Etienne Millon <me@emillon.org>
emillon
added a commit
that referenced
this pull request
Apr 17, 2024
* test: demonstrate overflow with sendfile (#10334) See #10333 Signed-off-by: Etienne Millon <me@emillon.org> * fix: use `Long_val` for sendfile() parameters to fix file copying in docker (#10333) * fix: sendfile() in docker Signed-off-by: Haoxiang Fei <feihaoxiang2014@gmail.com> * use ssize_t for return value Co-authored-by: Etienne Millon <etienne.millon@gmail.com> Signed-off-by: Haoxiang Fei <tonyfettes@tonyfettes.com> * update test Signed-off-by: Etienne Millon <me@emillon.org> * Add changelog Signed-off-by: Etienne Millon <me@emillon.org> --------- Signed-off-by: Haoxiang Fei <feihaoxiang2014@gmail.com> Signed-off-by: Haoxiang Fei <tonyfettes@tonyfettes.com> Signed-off-by: Etienne Millon <me@emillon.org> Co-authored-by: Etienne Millon <etienne.millon@gmail.com> Co-authored-by: Etienne Millon <me@emillon.org> * fix formatting (#10356) Signed-off-by: Etienne Millon <me@emillon.org> * move changelog entry to the right place (#10375) Signed-off-by: Etienne Millon <me@emillon.org> --------- Signed-off-by: Etienne Millon <me@emillon.org> Signed-off-by: Haoxiang Fei <feihaoxiang2014@gmail.com> Signed-off-by: Haoxiang Fei <tonyfettes@tonyfettes.com> Co-authored-by: Haoxiang Fei <tonyfettes@tonyfettes.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10333