Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: demonstrate overflow with sendfile #10334

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

emillon
Copy link
Collaborator

@emillon emillon commented Mar 29, 2024

See #10333

@emillon
Copy link
Collaborator Author

emillon commented Apr 2, 2024

ok so actually truncate makes a sparse file, but sendfile doesn't preserve holes in files (at least on ext4), so the test takes ~4s. The benefit / time balance doesn't feel in favor of enabling the test by default, I'll add a note about that.

See ocaml#10333

Signed-off-by: Etienne Millon <me@emillon.org>
@emillon emillon force-pushed the test-sendfile-overflow branch from 70e81c4 to 0825e64 Compare April 2, 2024 08:26
@emillon emillon merged commit 3796663 into ocaml:main Apr 2, 2024
9 of 10 checks passed
pmwhite pushed a commit to pmwhite/dune that referenced this pull request Apr 2, 2024
See ocaml#10333

Signed-off-by: Etienne Millon <me@emillon.org>
@emillon emillon mentioned this pull request Apr 17, 2024
emillon added a commit to emillon/dune that referenced this pull request Apr 17, 2024
See ocaml#10333

Signed-off-by: Etienne Millon <me@emillon.org>
emillon added a commit to emillon/dune that referenced this pull request Apr 17, 2024
See ocaml#10333

Signed-off-by: Etienne Millon <me@emillon.org>
emillon added a commit to emillon/dune that referenced this pull request Apr 17, 2024
See ocaml#10333

Signed-off-by: Etienne Millon <me@emillon.org>
emillon added a commit that referenced this pull request Apr 17, 2024
* test: demonstrate overflow with sendfile (#10334)

See #10333

Signed-off-by: Etienne Millon <me@emillon.org>

* fix: use `Long_val` for sendfile() parameters to fix file copying in docker (#10333)

* fix: sendfile() in docker

Signed-off-by: Haoxiang Fei <feihaoxiang2014@gmail.com>

* use ssize_t for return value

Co-authored-by: Etienne Millon <etienne.millon@gmail.com>
Signed-off-by: Haoxiang Fei <tonyfettes@tonyfettes.com>

* update test

Signed-off-by: Etienne Millon <me@emillon.org>

* Add changelog

Signed-off-by: Etienne Millon <me@emillon.org>

---------

Signed-off-by: Haoxiang Fei <feihaoxiang2014@gmail.com>
Signed-off-by: Haoxiang Fei <tonyfettes@tonyfettes.com>
Signed-off-by: Etienne Millon <me@emillon.org>
Co-authored-by: Etienne Millon <etienne.millon@gmail.com>
Co-authored-by: Etienne Millon <me@emillon.org>

* fix formatting (#10356)

Signed-off-by: Etienne Millon <me@emillon.org>

* move changelog entry to the right place (#10375)

Signed-off-by: Etienne Millon <me@emillon.org>

---------

Signed-off-by: Etienne Millon <me@emillon.org>
Signed-off-by: Haoxiang Fei <feihaoxiang2014@gmail.com>
Signed-off-by: Haoxiang Fei <tonyfettes@tonyfettes.com>
Co-authored-by: Haoxiang Fei <tonyfettes@tonyfettes.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants